Bug 121506

Summary: Add isTextOrBR() and use it
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch darin: review+

Antti Koivisto
Reported 2013-09-17 10:55:55 PDT
It is a popular test.
Attachments
patch (9.81 KB, patch)
2013-09-17 10:59 PDT, Antti Koivisto 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-09-17 10:59:02 PDT
Created attachment 211923 [details] patch
Darin Adler
Comment 2 2013-09-17 11:04:51 PDT
Comment on attachment 211923 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=211923&action=review > Source/WebCore/rendering/RenderCounter.cpp:111 > - if (object->isText() && !object->isBR()) > + if (object->isText()) Aha! ;-) > Source/WebCore/rendering/RenderTreeAsText.cpp:592 > - if (o.isText() && !o.isBR()) { > + if (o.isText()) { Glad this made you find these.
Antti Koivisto
Comment 3 2013-09-17 11:09:15 PDT
https://trac.webkit.org/r155975
Note You need to log in before you can comment on or make changes to this bug.