Bug 121479

Summary:

Move text caret rect computation to root inline box

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+

Description Antti Koivisto 2013-09-17 04:03:39 PDT

For future code sharing.

Comment 1 Antti Koivisto 2013-09-17 04:10:42 PDT

Created attachment 211884 [details]
patch

Comment 2 Andreas Kling 2013-09-17 04:19:14 PDT

Comment on attachment 211884 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211884&action=review

> Source/WebCore/rendering/RootInlineBox.h:138
> +    IntRect computeCaretRect(float left, unsigned caretWidth, LayoutUnit* extraWidthToEndOfLine);

Can this be const?

Comment 3 Antti Koivisto 2013-09-17 05:35:43 PDT

https://trac.webkit.org/r155949