Bug 121464

Summary: Remove unused function didSetSelectionTypesForPasteboard from EditorClient
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: HTML EditingAssignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eflews.bot, gtk-ews, gyuyoung.kim, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+, webkit-ews: commit-queue-

Enrica Casucci
Reported 2013-09-16 18:04:46 PDT
The only existing implementation is for WebKit on Mac which is calling a private delegate which is also unused.
Attachments
Patch (17.69 KB, patch)
2013-09-16 18:33 PDT, Enrica Casucci 		darin: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2013-09-16 18:33:07 PDT
Created attachment 211851 [details] Patch
Early Warning System Bot
Comment 2 2013-09-16 18:40:00 PDT
Comment on attachment 211851 [details] Patch Attachment 211851 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1813268
EFL EWS Bot
Comment 3 2013-09-16 20:08:22 PDT
Comment on attachment 211851 [details] Patch Attachment 211851 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1833059
kov's GTK+ EWS bot
Comment 4 2013-09-16 22:51:40 PDT
Comment on attachment 211851 [details] Patch Attachment 211851 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1907128
Early Warning System Bot
Comment 5 2013-09-17 02:26:14 PDT
Comment on attachment 211851 [details] Patch Attachment 211851 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1869348
Darin Adler
Comment 6 2013-09-17 09:20:39 PDT
One of the errors: CMakeFiles/WebKit.dir/efl/WebCoreSupport/EditorClientEfl.cpp.o:(.data.rel.ro._ZTVN7WebCore15EditorClientEflE[_ZTVN7WebCore15EditorClientEflE]+0x1a0): undefined reference to `WebCore::EditorClientEfl::didSetSelectionTypesForPasteboard()' Need to do a bit more grepping and deleting I think.
Enrica Casucci
Comment 7 2013-09-17 10:19:30 PDT
I fixed the builds for qt, gtk and elf. Committed revision 155971.
Note You need to log in before you can comment on or make changes to this bug.