Bug 121459

Summary:

Add RunLoop::isMain and use it in WebKit2

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, benjamin, cgarcia, commit-queue, gustavo, joepeck, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	andersca: review+, commit-queue: commit-queue-

Joseph Pecoraro

Reported 2013-09-16 15:35:59 PDT

Rather than "thread" logic like isMainThread we should use RunLoop logic.

Attachments
[PATCH] Proposed Fix (12.73 KB, patch) 2013-09-16 15:37 PDT, Joseph Pecoraro	andersca: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2013-09-16 15:37:58 PDT

Created attachment 211838 [details] [PATCH] Proposed Fix

WebKit Commit Bot

Comment 2 2013-09-16 15:40:11 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

WebKit Commit Bot

Comment 3 2013-09-16 15:46:13 PDT

Comment on attachment 211838 [details] [PATCH] Proposed Fix Rejecting attachment 211838 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 211838, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/1869241

Darin Adler

Comment 4 2013-09-16 15:49:48 PDT

Comment on attachment 211838 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=211838&action=review > Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm:126 > + ASSERT(RunLoop::isMain()); // This funciton calls the client, which should only be done on main thread. funciton!

Joseph Pecoraro

Comment 5 2013-09-16 16:31:50 PDT

Committed <http://trac.webkit.org/changeset/155911>.

Note You need to log in before you can comment on or make changes to this bug.