Bug 121448

Summary:

Fix creation of embedded JS and CSS files on cmake based ports.

Product:

WebKit

Reporter:

Hugo Parente Lima <hugo.lima>

Component:

WebCore Misc.

Assignee:

Hugo Parente Lima <hugo.lima>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gyuyoung.kim, joepeck, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Hugo Parente Lima

Reported 2013-09-16 12:29:23 PDT

After r155790 JavaScript and CSS files aren't embedded correctly due to a fail on js/css minimization process. CMake expands the macros to: /usr/bin/python2 WEBKITDIR/Source/WebCore/inspector/Scripts/cssmin.py "<WEBKITDIR/Source/WebCore/xml/XMLViewer.css" > WEBKITDIR/WebKitBuild/Release/DerivedSources/WebCore/XMLViewer.min.css instead of: /usr/bin/python2 WEBKITDIR/Source/WebCore/inspector/Scripts/cssmin.py < WEBKITDIR/Source/WebCore/xml/XMLViewer.css > WEBKITDIR/WebKitBuild/Release/DerivedSources/WebCore/XMLViewer.min.css

Attachments
Patch (4.66 KB, patch) 2013-09-16 12:40 PDT, Hugo Parente Lima	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Hugo Parente Lima

Comment 1 2013-09-16 12:40:51 PDT

Created attachment 211821 [details] Patch

Joseph Pecoraro

Comment 2 2013-09-16 12:45:41 PDT

Comment on attachment 211821 [details] Patch r=me, thanks!

WebKit Commit Bot

Comment 3 2013-09-16 14:45:10 PDT

Comment on attachment 211821 [details] Patch Clearing flags on attachment: 211821 Committed r155903: <http://trac.webkit.org/changeset/155903>

WebKit Commit Bot

Comment 4 2013-09-16 14:45:12 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.