Bug 121446

Summary:

WTF::Deque should work with move only types

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Anders Carlsson

Reported 2013-09-16 12:20:55 PDT

WTF::Deque should work with move only types

Attachments
Patch (6.99 KB, patch) 2013-09-16 12:24 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (6.36 KB, patch) 2013-09-16 12:34 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (6.36 KB, patch) 2013-09-16 12:41 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2013-09-16 12:24:06 PDT

Created attachment 211818 [details] Patch

WebKit Commit Bot

Comment 2 2013-09-16 12:25:58 PDT

Attachment 211818 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Deque.h', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/Tests/WTF/Deque.cpp']" exit_code: 1 Source/WTF/wtf/Deque.h:81: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/Deque.h:82: Missing spaces around && [whitespace/operators] [3] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 3 2013-09-16 12:34:05 PDT

Comment on attachment 211818 [details] Patch Attachment 211818 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1916497

Anders Carlsson

Comment 4 2013-09-16 12:34:49 PDT

Created attachment 211820 [details] Patch

WebKit Commit Bot

Comment 5 2013-09-16 12:37:08 PDT

Attachment 211820 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Deque.h', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/Tests/WTF/Deque.cpp']" exit_code: 1 Source/WTF/wtf/Deque.h:81: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/Deque.h:82: Missing spaces around && [whitespace/operators] [3] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 6 2013-09-16 12:41:12 PDT

Created attachment 211822 [details] Patch

WebKit Commit Bot

Comment 7 2013-09-16 12:44:12 PDT

Attachment 211822 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Deque.h', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/Tests/WTF/Deque.cpp']" exit_code: 1 Source/WTF/wtf/Deque.h:81: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/Deque.h:82: Missing spaces around && [whitespace/operators] [3] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 8 2013-09-16 13:38:15 PDT

Comment on attachment 211822 [details] Patch Clearing flags on attachment: 211822 Committed r155898: <http://trac.webkit.org/changeset/155898>

WebKit Commit Bot

Comment 9 2013-09-16 13:38:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.