Bug 121442 – AX: Mac AXARIABusy should be AXElementBusy (not ARIA specific)

• Component: Accessibility
• Status: RESOLVED FIXED

[James Craig]

AX: Mac AXARIABusy should not be ARIA-specific; perhaps AXBusy? Unlike the live region properties, the general concept of an element in a busy state (while loading, initializing, etc.) is not specific to ARIA, so the API property should not reference ARIA. I'm leaning toward AXBusy, though AXElementBusy might be a little more precise.

[Radar WebKit Bug Importer]

<rdar://problem/15000561>

[Samuel White]

Created attachment 211928 [details]
Patch.

Renamed AXARIABusy attribute to AXElementBusy and updated layout tests.

[chris fleizach]

Comment on attachment 211928 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=211928&action=review

> LayoutTests/platform/mac/accessibility/aria-liveregions-attributes-expected.txt:18
> +FAIL accessibilityController.focusedElement.isAttributeSupported('AXElementBusy') should be false. Was true.

why is this a fail?
i know it was there before but it seems wrong

[Samuel White]

Created attachment 211938 [details]
Patch.

[Samuel White]

(In reply to comment #3)
> (From update of attachment 211928 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211928&action=review
> 
> > LayoutTests/platform/mac/accessibility/aria-liveregions-attributes-expected.txt:18
> > +FAIL accessibilityController.focusedElement.isAttributeSupported('AXElementBusy') should be false. Was true.
> 
> why is this a fail?
> i know it was there before but it seems wrong

Agreed, this was definitely wrong. I suspect this was leftover from a time when ONLY live regions supported aria-busy (AXARIABusy at the platform level).

Comment evidence (line 1016 of WebAccessibilityObjectWrapperMac.mm):

// All objects should expose the ARIA busy attribute (ARIA 1.1 with ISSUE-538).

[chris fleizach]

(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 211928 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=211928&action=review
> > 
> > > LayoutTests/platform/mac/accessibility/aria-liveregions-attributes-expected.txt:18
> > > +FAIL accessibilityController.focusedElement.isAttributeSupported('AXElementBusy') should be false. Was true.
> > 
> > why is this a fail?
> > i know it was there before but it seems wrong
> 
> Agreed, this was definitely wrong. I suspect this was leftover from a time when ONLY live regions supported aria-busy (AXARIABusy at the platform level).
> 
> Comment evidence (line 1016 of WebAccessibilityObjectWrapperMac.mm):
> 
> // All objects should expose the ARIA busy attribute (ARIA 1.1 with ISSUE-538).

I guess we should change it to use shouldBeTrue then since it's supported on all elements

[chris fleizach]

Comment on attachment 211938 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=211938&action=review

> LayoutTests/ChangeLog:3
> +        AX: Mac AXARIABusy should not be ARIA-specific; perhaps AXBusy?

let's update the bug title so that it reflects what we did

[Samuel White]

Created attachment 211948 [details]
Patch.

Patch with updated title.

[WebKit Commit Bot]

Comment on attachment 211948 [details]
Patch.

Clearing flags on attachment: 211948

Committed r156011: <http://trac.webkit.org/changeset/156011>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.