Summary: | AX: Mac AXARIABusy should be AXElementBusy (not ARIA specific) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Craig <jcraig> | ||||||||
Component: | Accessibility | Assignee: | Samuel White <samuel_white> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jdiggs, mario, samuel_white, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.8 | ||||||||||
Attachments: |
|
Description
James Craig
2013-09-16 11:00:10 PDT
Created attachment 211928 [details]
Patch.
Renamed AXARIABusy attribute to AXElementBusy and updated layout tests.
Comment on attachment 211928 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=211928&action=review > LayoutTests/platform/mac/accessibility/aria-liveregions-attributes-expected.txt:18 > +FAIL accessibilityController.focusedElement.isAttributeSupported('AXElementBusy') should be false. Was true. why is this a fail? i know it was there before but it seems wrong Created attachment 211938 [details]
Patch.
(In reply to comment #3) > (From update of attachment 211928 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=211928&action=review > > > LayoutTests/platform/mac/accessibility/aria-liveregions-attributes-expected.txt:18 > > +FAIL accessibilityController.focusedElement.isAttributeSupported('AXElementBusy') should be false. Was true. > > why is this a fail? > i know it was there before but it seems wrong Agreed, this was definitely wrong. I suspect this was leftover from a time when ONLY live regions supported aria-busy (AXARIABusy at the platform level). Comment evidence (line 1016 of WebAccessibilityObjectWrapperMac.mm): // All objects should expose the ARIA busy attribute (ARIA 1.1 with ISSUE-538). (In reply to comment #5) > (In reply to comment #3) > > (From update of attachment 211928 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=211928&action=review > > > > > LayoutTests/platform/mac/accessibility/aria-liveregions-attributes-expected.txt:18 > > > +FAIL accessibilityController.focusedElement.isAttributeSupported('AXElementBusy') should be false. Was true. > > > > why is this a fail? > > i know it was there before but it seems wrong > > Agreed, this was definitely wrong. I suspect this was leftover from a time when ONLY live regions supported aria-busy (AXARIABusy at the platform level). > > Comment evidence (line 1016 of WebAccessibilityObjectWrapperMac.mm): > > // All objects should expose the ARIA busy attribute (ARIA 1.1 with ISSUE-538). I guess we should change it to use shouldBeTrue then since it's supported on all elements Comment on attachment 211938 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=211938&action=review > LayoutTests/ChangeLog:3 > + AX: Mac AXARIABusy should not be ARIA-specific; perhaps AXBusy? let's update the bug title so that it reflects what we did Created attachment 211948 [details]
Patch.
Patch with updated title.
Comment on attachment 211948 [details] Patch. Clearing flags on attachment: 211948 Committed r156011: <http://trac.webkit.org/changeset/156011> All reviewed patches have been landed. Closing bug. |