| Summary: | [GTK][EFL] Add ResourceError::internalError() after r138387 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | beidson, cdumez, commit-queue, gyuyoung.kim, kbalazs, ossy, philn, rakuco, skyul, xan.lopez | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 110141 | ||||||||
| Attachments: |
|
||||||||
|
Description
Csaba Osztrogonác
2013-09-16 08:21:30 PDT
Created attachment 211788 [details] Patch I fixed the GTK implementation as Kwang Yul Seo noticed in https://bugs.webkit.org/show_bug.cgi?id=110141#c13 Created attachment 211873 [details]
Patch
glib/gi18n-lib.h added to fix the GTK build.
Comment on attachment 211873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211873&action=review > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:75 > +WebCore::ResourceError internalError(const WebCore::KURL& url) Shouldn't we protect this with #if ENABLE(NETWORK_PROCESS) ? > Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:78 > +WebCore::ResourceError internalError(const WebCore::KURL& url) Ditto. Comment on attachment 211873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211873&action=review >> Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:75 >> +WebCore::ResourceError internalError(const WebCore::KURL& url) > > Shouldn't we protect this with #if ENABLE(NETWORK_PROCESS) ? internalError() is called from only ENABLE(NETWORK_PROCESS) blocks, but it builds now with !ENABLE(NETWORK_PROCESS). I don't think if we should add guards not to have unreachable code. It is the job of the linker to get rid these unused functions. Comment on attachment 211873 [details]
Patch
I don't really mind either way so r+. There is no guard in WebErrors.h anyway.
Comment on attachment 211873 [details] Patch Clearing flags on attachment: 211873 Committed r155942: <http://trac.webkit.org/changeset/155942> All reviewed patches have been landed. Closing bug. |