[GTK] Cannot find WebInspectorUI/UserInterface/Main.html referenced in GResourceBundle.xml

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Xabier Rodríguez Calvar]

When building WebKit from upstream in GNOME Jhbuild with moduleset 3.10 I am getting this problem

./DerivedSources/WebInspectorUI/GResourceBundle.xml: Error on line 5 char 1: Failed to locate 'Source/WebInspectorUI/UserInterface/Main.html' in any source directory.

[Xabier Rodríguez Calvar]

The autogen.sh is run with the following options that hadn't been a problem so far:

--enable-introspection --disable-static --enable-introspection --disable-gtk-doc --disable-introspection --enable-silent-rules

[Gustavo Noronha (kov)]

Hmm, is that using a specific tarball release?

[Xabier Rodríguez Calvar]

(In reply to comment #2)
> Hmm, is that using a specific tarball release?

No, I just use latest version and to not interfere with my upstream compilation, I just clone it by using

git archive --format=tar svn-trunk | (cd /my/destination/inside/gnome/jhbuild/ && tar xf -)

[Gustavo Noronha (kov)]

And I guess the tarball that's being generated by git archive (I have only recently been introduced to it) not including that file?

[Xabier Rodríguez Calvar]

(In reply to comment #4)
> And I guess the tarball that's being generated by git archive (I have only recently been introduced to it) not including that file?

Nope, the file is there.

[Gustavo Noronha (kov)]

OK, I came up with a theory and it looks like it's correct: this only happens if you have srcdir == builddir (which is why we haven't noticed yet), and is caused by automake helpfully resolving the paths of the dependencies of a target, thus removing the useless ./ (that is $(srcdir), which is used to form $(WebInspectorUI)), but keeps that useless ./ in the actual WebInspectorUI variable, so my sed for normalizing the paths was not replacing anything in that case. Patch incoming, just testing with srcdir != builddir now.

[Gustavo Noronha (kov)]

Created attachment 211962 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 211962 [details]
Patch

Clearing flags on attachment: 211962

Committed r156027: <http://trac.webkit.org/changeset/156027>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

I wonder why commit queue didn't use your e-mail for this commit: <http://trac.webkit.org/changeset/156027>.

Perhaps your data in committers.json is not up to date?

[Gustavo Noronha (kov)]

It seems to be up-to-date, that file has my name and the [e-mail] email. I wonder if the svn post-commit script is only rewriting the email used as username for committing (that would be [e-mail])