Bug 121403

Summary: MediaStream API: Adding an async RTCPeerConnection::addIceCandidate
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, glenn, hta, jer.noble, kondapallykalyan, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121101    
Attachments:
Description Flags
Proposed patch none

Description Eric Carlson 2013-09-15 14:26:11 PDT 
Consider merging/adapting https://chromium.googlesource.com/chromium/blink/+/5bd81fda88d48dd2780832246e7d1ab973ee7a1d

RTCPeerConnection::addIceCandidate has changed to by async.
Comment 1 Eric Carlson 2013-09-16 19:30:24 PDT 
Created attachment 211857 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2013-09-17 07:17:48 PDT 
Comment on attachment 211857 [details]
Proposed patch

Rejecting attachment 211857 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 211857, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/1869424
Comment 3 Eric Carlson 2013-09-17 07:51:59 PDT 
Committed r155954: https://trac.webkit.org/r155954