Bug 121403 - MediaStream API: Adding an async RTCPeerConnection::addIceCandidate
Summary: MediaStream API: Adding an async RTCPeerConnection::addIceCandidate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks: 121101
  Show dependency tree / graph
 
Reported: 2013-09-15 14:26 PDT by Eric Carlson
Modified: 2013-09-17 07:52 PDT (History)
8 users (show)

See Also:

Attachments
Proposed patch (8.87 KB, patch)
2013-09-16 19:30 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-09-15 14:26:11 PDT 
Consider merging/adapting https://chromium.googlesource.com/chromium/blink/+/5bd81fda88d48dd2780832246e7d1ab973ee7a1d

RTCPeerConnection::addIceCandidate has changed to by async.
Comment 1 Eric Carlson 2013-09-16 19:30:24 PDT 
Created attachment 211857 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2013-09-17 07:17:48 PDT 
Comment on attachment 211857 [details]
Proposed patch

Rejecting attachment 211857 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 211857, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/1869424
Comment 3 Eric Carlson 2013-09-17 07:51:59 PDT 
Committed r155954: https://trac.webkit.org/r155954