Bug 121338

Summary: There is no need for any custom bindings for Console
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, graouts, gyuyoung.kim, joepeck, kondapallykalyan, philn, rakuco, timothy, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 121342    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Updated patch timothy: review+

Sam Weinig
Reported 2013-09-13 18:39:06 PDT
There is no need for any custom bindings for Console
Attachments
Patch (22.10 KB, patch)
2013-09-13 18:42 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Updated patch (22.14 KB, patch)
2013-09-14 11:22 PDT, Sam Weinig 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-09-13 18:42:16 PDT
Created attachment 211612 [details] Patch
Joseph Pecoraro
Comment 2 2013-09-13 18:45:49 PDT
Comment on attachment 211612 [details] Patch r=me!
Sam Weinig
Comment 3 2013-09-13 18:49:48 PDT
Committed r155738: <http://trac.webkit.org/changeset/155738>
WebKit Commit Bot
Comment 4 2013-09-13 21:41:15 PDT
Re-opened since this is blocked by bug 121342
Alexey Proskuryakov
Comment 5 2013-09-13 21:41:42 PDT
This change broke lots of tests and Sam is not online, rolling out. http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r155741%20(15389)/results.html
Sam Weinig
Comment 6 2013-09-14 11:22:47 PDT
Created attachment 211657 [details] Updated patch
Sam Weinig
Comment 7 2013-09-14 11:23:22 PDT
Updated patch to mark the title parameter as optional (which was what broke the tests).
Sam Weinig
Comment 8 2013-09-14 11:28:28 PDT
Committed r155774: <http://trac.webkit.org/changeset/155774>
Note You need to log in before you can comment on or make changes to this bug.