Bug 121315

Summary: Inspector Server: queue messages sent before socket connection is established
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: New BugsAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: cgarcia, commit-queue, graouts, joepeck, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch timothy: review-

Gustavo Noronha (kov)
Reported 2013-09-13 12:41:00 PDT
Inspector Server: queue messages sent before socket connection is established
Attachments
Patch (4.00 KB, patch)
2013-09-13 12:46 PDT, Gustavo Noronha (kov)
timothy: review-
Gustavo Noronha (kov)
Comment 1 2013-09-13 12:46:16 PDT
Timothy Hatcher
Comment 2 2013-09-16 09:59:24 PDT
Comment on attachment 211576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211576&action=review > Source/WebInspectorUI/UserInterface/InspectorFrontendHostStub.js:118 > + remoteConnected: function() > + { > + for (i = 0; i < this._messagesQueue.length; i++) > + WebInspector.socket.send(this._messagesQueue[i]); > + > + delete this._messagesQueue; > + }, > + > sendMessageToBackend: function(message) > { > + // Messages may be sent before the websocket is connected, in which case > + // queue them for sending as soon as the connection is established. > if (WebInspector.socket) > WebInspector.socket.send(message); > + else > + this._messagesQueue.push(message); This duplicates a patch I have on bug 121391.
Timothy Hatcher
Comment 3 2013-09-16 10:04:48 PDT
*** This bug has been marked as a duplicate of bug 121391 ***
Note You need to log in before you can comment on or make changes to this bug.