Bug 121296

Summary: [GTK] Fails to compile if the build directory is in a different partition
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKitGTKAssignee: Alberto Garcia <berto>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
cgarcia: review+
Patch mrobinson: review+

Alberto Garcia
Reported 2013-09-13 05:25:48 PDT
The problem is the os.link() call in gtkdoc.py
Attachments
Patch (1.10 KB, patch)
2013-09-13 05:27 PDT, Alberto Garcia 		cgarcia: review+
DetailsFormatted DiffDiff
Patch (1.30 KB, patch)
2013-09-14 09:54 PDT, Alberto Garcia 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-09-13 05:27:04 PDT
Created attachment 211543 [details] Patch
Alberto Garcia
Comment 2 2013-09-14 01:35:08 PDT
Committed r155757: <http://trac.webkit.org/changeset/155757>
Martin Robinson
Comment 3 2013-09-14 08:51:51 PDT
os.symlink doesn't work on Windows.
Martin Robinson
Comment 4 2013-09-14 08:52:28 PDT
I think it sometimes works in cygwin, but not always.
Alberto Garcia
Comment 5 2013-09-14 09:07:46 PDT
Maybe we can try link() first and use symlink() if it fails.
Alberto Garcia
Comment 6 2013-09-14 09:54:00 PDT
Created attachment 211651 [details] Patch Ok, this patch reverts to using os.link() and only uses os.symlink() as a fallback.
Martin Robinson
Comment 7 2013-09-14 10:42:57 PDT
Comment on attachment 211651 [details] Patch Great. Thanks!
Alberto Garcia
Comment 8 2013-09-14 11:02:44 PDT
Committed r155772: <http://trac.webkit.org/changeset/155772>
Note You need to log in before you can comment on or make changes to this bug.