Bug 121288

Summary:

Remove support for anonymous deprecated flexboxes.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kling, koivisto, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2013-09-13 03:44:02 PDT

Looks like this is not needed anymore.

Comment 1 Andreas Kling 2013-09-13 03:59:14 PDT

Created attachment 211533 [details]
Patch

Comment 2 Antti Koivisto 2013-09-13 04:03:02 PDT

Nice!

Comment 3 Antti Koivisto 2013-09-13 04:04:01 PDT

Comment on attachment 211533 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211533&action=review

> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:-135
> -            FeatureObserver::observe(&document(), FeatureObserver::DeprecatedFlexboxChrome);
> -        else if (url.protocolIs("chrome-extension"))
> -            FeatureObserver::observe(&document(), FeatureObserver::DeprecatedFlexboxChromeExtension);
> -        else
> -            FeatureObserver::observe(&document(), FeatureObserver::DeprecatedFlexboxWebContent);

I guess we can nuke those FeatureObserver enum values too.

Comment 4 Andreas Kling 2013-09-13 05:21:33 PDT

Comment on attachment 211533 [details]
Patch

Clearing flags on attachment: 211533

Committed r155689: <http://trac.webkit.org/changeset/155689>

Comment 5 Andreas Kling 2013-09-13 05:21:38 PDT

All reviewed patches have been landed.  Closing bug.