Bug 121268

Summary: DFG::Int32Operand and fillInt32() should go away and all uses should be replaced with SpeculateInt32Operand
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, bfulgham, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 121064    
Attachments:
Description Flags
the patch oliver: review+

Filip Pizlo
Reported 2013-09-12 16:30:40 PDT
SpeculateInt32Operand is strictly more powerful than Int32Operand. It can even assert for you that you're not doing a speculation when you shouldn't be doing on, just like Int32Operand does. So we should get rid of Int32Operand.
Attachments
the patch (11.67 KB, patch)
2013-09-12 16:31 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-09-12 16:31:36 PDT
Created attachment 211491 [details] the patch
Oliver Hunt
Comment 2 2013-09-12 16:54:03 PDT
Comment on attachment 211491 [details] the patch nice
Filip Pizlo
Comment 3 2013-09-12 16:57:28 PDT
Landed in http://trac.webkit.org/changeset/155662
Filip Pizlo
Comment 5 2013-09-12 18:35:05 PDT
(In reply to comment #4) > This may have introduced crashing on ML Release builds. See http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/r155662%20%2812852%29/media/video-seek-after-end-crash-log.txt. Seems doubtful. That's a GC crash. GC crashes will be spurious to begin with. This patch changes how the compiler handles integers. The GC ignores integers. We should keep an eye on it, though.
Note You need to log in before you can comment on or make changes to this bug.