Bug 121259 – [GTK] Do not enable VIDEO_TRACK if VIDEO is disabled

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Alberto Garcia]

This is what we get if we try to compile with --no-video:

  CXX    Source/JavaScriptCore/llint/Programs_LLIntOffsetsExtractor-LLIntOffsetsExtractor.o
In file included from ../../Source/WTF/wtf/Platform.h:650:0,
                 from ../../Source/JavaScriptCore/config.h:30,
                 from ../../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:26:
../../Source/WTF/wtf/FeatureDefines.h:874:2: error: #error "ENABLE(VIDEO_TRACK) requires ENABLE(VIDEO)"

[Alberto Garcia]

Created attachment 211476 [details]
Patch

Here's the patch. It makes VIDEO_TRACK follow VIDEO.

Of course it's also possible to have a flag to configure them separately. Should we do that instead?

[Martin Robinson]

Comment on attachment 211476 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211476&action=review

> Tools/ChangeLog:9
> +        Make VIDEO_TRACK configurable because it needs to be disabled if
> +        VIDEO is also disabled.

Not sure I understand the change, since you say "because it needs to be disabled if VIDEO is also disabled," but it was always disabled before. What you are doing here is enabling VIDEO_TRACK for release builds if video is enabled. Perhaps you're really after some interaction with build-webkit?

[Martin Robinson]

Comment on attachment 211476 [details]
Patch

Apologies for how confusing the interaction of build-webkit and configure is, but the features defined in SetupWebKitFeatures.m4 describe the setup for release builds. We do not want to enable video track yet for release builds, so this patch isn't really correct. Furthermore, WebKitFeatureOverrides.txt should override any value you use here, I'm not sure it works.

[Alberto Garcia]

You're right, running build-webkit with --no-video-track is enough, for some reason I thought it was not working.

Sorry for the noise!