Bug 121235

Summary: Remove unneeded casts once we upgrade to a version of Visual Studio that is not broken
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: peavo
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, eric.carlson, peavo, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch darin: review+

Brent Fulgham
Reported 2013-09-12 10:37:52 PDT
We had to add casts in a number of places to work around a Visual Studio 2010 compiler bug. We should revisit this from time to time (perhaps after the switch to VS2012) to see if we can remove these casts. Locations: 1. WebCore/loader/archive/ArchiveFactory.cpp 2. WebCore/css/MediaQueryEvaluator.cpp 3. Autogenerated Files: JSSVGElementWrapperFactory.cpp JSHTMLElementWrapperFactory.cpp --> Modified in WebCore/dom/make_names.pl
Attachments
Patch (5.69 KB, patch)
2016-05-01 23:15 PDT, peavo 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-09-12 10:55:04 PDT
The changes we want to back out were landed in http://trac.webkit.org/changeset/155630.
Eric Carlson
Comment 2 2014-01-29 09:25:39 PST
Can the unneeded casts be removed now?
Simon Fraser (smfr)
Comment 3 2016-04-28 21:18:04 PDT
How about now?
Brent Fulgham
Comment 4 2016-04-29 11:25:55 PDT
(In reply to comment #3) > How about now? I'll bet they can! Per, could you please try and propose a patch?
peavo
Comment 5 2016-05-01 23:15:41 PDT
Created attachment 277892 [details] Patch
peavo
Comment 6 2016-05-02 13:34:11 PDT
Thanks for reviewing :)
peavo
Comment 7 2016-05-02 13:35:12 PDT
Committed r200336: <http://trac.webkit.org/changeset/200336>
Note You need to log in before you can comment on or make changes to this bug.