Bug 121230

Summary: SharedBuffer::createCFData should return RetainPtr<CFDataRef>
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Anders Carlsson
Reported 2013-09-12 09:38:22 PDT
SharedBuffer::createCFData should return RetainPtr<CFDataRef>
Attachments
Patch (10.94 KB, patch)
2013-09-12 09:39 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-09-12 09:39:25 PDT
Created attachment 211436 [details] Patch
Darin Adler
Comment 2 2013-09-12 09:40:47 PDT
Comment on attachment 211436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211436&action=review > Source/WebCore/platform/mac/SharedBufferMac.mm:109 > + return adoptCF((CFDataRef)adoptNS([[WebCoreSharedBufferData alloc] initWithSharedBuffer:this]).leakRef()); We’ve got to find a better idiom for toll free bridging with RetainPtr than this. It destroys the rule of “look for leakRef” to find bugs.
Anders Carlsson
Comment 3 2013-09-12 10:37:31 PDT
Committed r155629: <http://trac.webkit.org/changeset/155629>
Note You need to log in before you can comment on or make changes to this bug.