Summary: | SVGPathElement should not inherit from SVGPathParser | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | sam, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2007-01-05 01:09:40 PST
Created attachment 14845 [details]
First attempt
This is not a full fix for this bug, but it helps the SVGAnimateMotionElement problem. Let me know if that is enough for this bug and whether SVGPathElement should be changed too.
Cheers,
Rob.
Comment on attachment 14845 [details]
First attempt
It's a rather incomplete fix. Basically you're just adding another class to codify the existing hack of needing to allocate a class to do the parsing. If you're going to add this PathBuilder class, i would think you would make SVGPathElement use it too. I don't think that this fix is really much better than the existing hack. If you got rid of the other instances of classes inheriting from SVGPathParser, that would be a more complete fix. We can chat about this on IRC if you like.
Created attachment 14896 [details]
Addressing Eric's issues
This seems somewhat nicer IMHO.
Cheers,
Rob.
Comment on attachment 14896 [details]
Addressing Eric's issues
Looks good to me! Great work!
|