Bug 121205

Summary: Encapsulate globals in CSSPropertyAnimation.cpp
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: CSSAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, commit-queue, dino, dstockwell, esprehn+autocc, glenn, kling, koivisto, kondapallykalyan, simon.fraser, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121199    
Attachments:
Description Flags
Cleanup koivisto: review+, webkit-ews: commit-queue-

Ryosuke Niwa
Reported 2013-09-11 19:43:01 PDT
We have three globals in this file. Encapsulate them inside a class in the preparation to fix the bug 121199.
Attachments
Cleanup (13.70 KB, patch)
2013-09-11 19:56 PDT, Ryosuke Niwa 		koivisto: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-09-11 19:56:30 PDT
Created attachment 211390 [details] Cleanup
Early Warning System Bot
Comment 2 2013-09-11 20:04:37 PDT
Comment on attachment 211390 [details] Cleanup Attachment 211390 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1797027
Early Warning System Bot
Comment 3 2013-09-11 20:08:50 PDT
Comment on attachment 211390 [details] Cleanup Attachment 211390 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1830028
Antti Koivisto
Comment 4 2013-09-12 09:26:17 PDT
Comment on attachment 211390 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=211390&action=review > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1086 > + map->ensurePropertyMap(); // FIXME: ensurePropertyMap() calls instance() inside addShorthandProperties(). initialize() might be a better name. We usually use ensure* for functions that return a value.
Ryosuke Niwa
Comment 5 2013-09-12 13:51:08 PDT
Committed r155647: <http://trac.webkit.org/changeset/155647>
Ryosuke Niwa
Comment 6 2013-09-12 14:19:54 PDT
(In reply to comment #4) > (From update of attachment 211390 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=211390&action=review > > > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1086 > > + map->ensurePropertyMap(); // FIXME: ensurePropertyMap() calls instance() inside addShorthandProperties(). > > initialize() might be a better name. We usually use ensure* for functions that return a value. I'm getting rid of this function in the bug 121199.
Note You need to log in before you can comment on or make changes to this bug.