Bug 121194

Summary: Removed some unused functions from the debugger interface
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, graouts, joepeck, mark.lam, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch joepeck: review+

Geoffrey Garen
Reported 2013-09-11 17:34:29 PDT
Removed some unused functions from the debugger interface
Attachments
Patch (2.66 KB, patch)
2013-09-11 17:36 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (13.21 KB, patch)
2013-09-11 17:40 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (16.20 KB, patch)
2013-09-11 17:43 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (17.39 KB, patch)
2013-09-11 17:46 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (26.88 KB, patch)
2013-09-11 19:30 PDT, Geoffrey Garen 		joepeck: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2013-09-11 17:36:56 PDT
Created attachment 211369 [details] Patch
Geoffrey Garen
Comment 2 2013-09-11 17:40:15 PDT
Created attachment 211370 [details] Patch
Geoffrey Garen
Comment 3 2013-09-11 17:43:44 PDT
Created attachment 211371 [details] Patch
Geoffrey Garen
Comment 4 2013-09-11 17:46:39 PDT
Created attachment 211373 [details] Patch
Geoffrey Garen
Comment 5 2013-09-11 18:13:34 PDT
Comment on attachment 211373 [details] Patch Looks like I need to update a layout tests. Stay tuned...
Timothy Hatcher
Comment 6 2013-09-11 18:14:02 PDT
Comment on attachment 211373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211373&action=review > Source/WebCore/inspector/InjectedScript.cpp:-101 > - ScriptFunctionCall function(injectedScriptObject(), "restartFrame"); restartFrame can be removed from InjectedScriptSource.js too. > Source/WebCore/inspector/InjectedScript.cpp:-121 > - ScriptFunctionCall function(injectedScriptObject(), "setVariableValue"); setVariableValue can be removed from InjectedScriptSource.js too.
Geoffrey Garen
Comment 7 2013-09-11 19:30:12 PDT
Created attachment 211387 [details] Patch
Joseph Pecoraro
Comment 8 2013-09-11 19:39:52 PDT
Comment on attachment 211387 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211387&action=review r=me > Source/WebCore/inspector/InjectedScriptSource.js:-692 > - setter = InjectedScriptHost.setFunctionVariableValue.bind(InjectedScriptHost, func); This is the only user of InjectedScriptHost.setFunctionVariableValue.bind. It is equally stubbed so you can remove that too! - WebCore/bindings/js/JSInjectedScriptHostCustom.cpp stub - WebCore/inspector/InjectedScriptExterns.js stub - WebCore/inspector/InjectedScriptHost.idl [Custom]
Geoffrey Garen
Comment 9 2013-09-11 20:07:21 PDT
Committed r155589: <http://trac.webkit.org/changeset/155589>
Geoffrey Garen
Comment 10 2013-09-11 20:08:01 PDT
Thanks!
Note You need to log in before you can comment on or make changes to this bug.