| Summary: | Removed some unused functions from the debugger interface | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||||||||||
| Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, ddkilzer, graouts, joepeck, mark.lam, timothy | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Geoffrey Garen
2013-09-11 17:34:29 PDT
Created attachment 211369 [details]
Patch
Created attachment 211370 [details]
Patch
Created attachment 211371 [details]
Patch
Created attachment 211373 [details]
Patch
Comment on attachment 211373 [details]
Patch
Looks like I need to update a layout tests. Stay tuned...
Comment on attachment 211373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211373&action=review > Source/WebCore/inspector/InjectedScript.cpp:-101 > - ScriptFunctionCall function(injectedScriptObject(), "restartFrame"); restartFrame can be removed from InjectedScriptSource.js too. > Source/WebCore/inspector/InjectedScript.cpp:-121 > - ScriptFunctionCall function(injectedScriptObject(), "setVariableValue"); setVariableValue can be removed from InjectedScriptSource.js too. Created attachment 211387 [details]
Patch
Comment on attachment 211387 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211387&action=review r=me > Source/WebCore/inspector/InjectedScriptSource.js:-692 > - setter = InjectedScriptHost.setFunctionVariableValue.bind(InjectedScriptHost, func); This is the only user of InjectedScriptHost.setFunctionVariableValue.bind. It is equally stubbed so you can remove that too! - WebCore/bindings/js/JSInjectedScriptHostCustom.cpp stub - WebCore/inspector/InjectedScriptExterns.js stub - WebCore/inspector/InjectedScriptHost.idl [Custom] Committed r155589: <http://trac.webkit.org/changeset/155589> Thanks! |