Bug 121187

Summary: [CSS Shapes] Turn shape's logicalwidth/height into a LayoutSize
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: CSSAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89256    
Attachments:
Description Flags
proposed patch
none
proposed patch none

Zoltan Horvath
Reported 2013-09-11 15:45:06 PDT
Turn shape's logicalwidth/height into a LayoutSize
Attachments
proposed patch (4.02 KB, patch)
2013-09-11 15:51 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
proposed patch (4.38 KB, patch)
2013-09-11 16:12 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2013-09-11 15:51:34 PDT
Created attachment 211360 [details] proposed patch
Zoltan Horvath
Comment 2 2013-09-11 16:12:08 PDT
Created attachment 211362 [details] proposed patch
Dave Hyatt
Comment 3 2013-09-12 09:26:58 PDT
Comment on attachment 211362 [details] proposed patch r=me
Dave Hyatt
Comment 4 2013-09-12 09:27:33 PDT
Comment on attachment 211362 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=211362&action=review > Source/WebCore/rendering/shapes/ShapeInfo.h:99 > + LayoutUnit shapeContainingBlockHeight() const { return (m_renderer->style()->boxSizing() == CONTENT_BOX) ? (m_shapeLogicalSize.height() + m_renderer->borderAndPaddingLogicalHeight()) : m_shapeLogicalSize.height(); } Just an observation for a future patch, but this should really be shapeContainingBockLogicalHeight().
WebKit Commit Bot
Comment 5 2013-09-12 09:48:41 PDT
Comment on attachment 211362 [details] proposed patch Clearing flags on attachment: 211362 Committed r155626: <http://trac.webkit.org/changeset/155626>
WebKit Commit Bot
Comment 6 2013-09-12 09:48:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.