Bug 121184

Summary: REGRESSION (r155561): extract-localizable-strings can miss strings
Product: WebKit Reporter: mitz
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, mrowe
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Don’t discard lines while waiting for ) or ] darin: review+

mitz
Reported 2013-09-11 14:54:11 PDT
Created attachment 211355 [details] Don’t discard lines while waiting for ) or ] I didn’t notice that I’d introduced this bug because it doesn’t affect any of the files update-webkit-localizable-strings processes.
Attachments
Don’t discard lines while waiting for ) or ] (1.09 KB, patch)
2013-09-11 14:54 PDT, mitz
darin: review+
WebKit Commit Bot
Comment 1 2013-09-11 15:05:20 PDT
Attachment 211355 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/extract-localizable-strings']" exit_code: 1 Tools/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 2 2013-09-11 15:06:32 PDT
Note You need to log in before you can comment on or make changes to this bug.