Bug 121178

Summary: update-webkit-localizable-strings is at least 5.8x slower than it should be
Product: WebKit Reporter: mitz
Component: Tools / TestsAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: darin, jberlin, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Make update-webkit-localizable-strings 5.8x faster darin: review+

mitz
Reported 2013-09-11 12:43:08 PDT
update-webkit-localizable-strings is at least 5.8x slower than it should be
Attachments
Make update-webkit-localizable-strings 5.8x faster (1.31 KB, patch)
2013-09-11 12:59 PDT, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2013-09-11 12:59:53 PDT
Created attachment 211342 [details] Make update-webkit-localizable-strings 5.8x faster
Darin Adler
Comment 2 2013-09-11 13:56:39 PDT
There are lots of tricks to make regular expressions faster in perl. For example, I think non-capturing parentheses are faster, and maybe two separate regular expressions might be faster than then using “|”.
mitz
Comment 3 2013-09-11 14:02:14 PDT
Fixed in <http://trac.webkit.org/r155561>.
Note You need to log in before you can comment on or make changes to this bug.