Bug 121176

Summary:

HTMLEntityTable could use char to reduce binary size

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, esprehn+autocc, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	andersca: review+

Description Simon Fraser (smfr) 2013-09-11 12:19:42 PDT

static const UChar zwnjSemicolonEntityName[] = {'z', 'w', 'n', 'j', ';'};

static const HTMLEntityTableEntry staticEntityTable[2231] = {
    { AEligEntityName, 5, 0x000C6, 0 },


Pretty sure we could use char to save space.

Symbols says:
            0x0000000000eada30 (  0xd130) WebCore::(anonymous namespace)::staticEntityTable [NameNList, MangledNameNList, NList] 
            0x0000000000d6cc30 (     0xa) WebCore::(anonymous namespace)::AEligEntityName [NameNList, MangledNameNList, NList] 
etc.

Comment 1 Ryosuke Niwa 2013-09-11 12:32:37 PDT

Let's fix this.

Comment 2 Ryosuke Niwa 2013-09-11 12:41:30 PDT

Created attachment 211340 [details]
Fixes the bug

Comment 3 Ryosuke Niwa 2013-09-11 13:45:55 PDT

Committed r155559: <http://trac.webkit.org/changeset/155559>