Bug 121171

Summary: Remove TimelineTraceEventProcessor since no current ports use it
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: New BugsAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch joepeck: review+, timothy: commit-queue-

Timothy Hatcher
Reported 2013-09-11 11:19:36 PDT
Remove TimelineTraceEventProcessor since no current ports use it
Attachments
Patch (36.25 KB, patch)
2013-09-11 11:20 PDT, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2013-09-11 11:20:08 PDT
Created attachment 211330 [details] Patch
Joseph Pecoraro
Comment 2 2013-09-11 11:34:10 PDT
Comment on attachment 211330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211330&action=review r=me > Source/WebCore/inspector/TimelineTraceEventProcessor.cpp:-167 > - registerHandler(InstrumentationEvents::BeginFrame, TracePhaseInstant, &TimelineTraceEventProcessor::onBeginFrame); > - registerHandler(InstrumentationEvents::PaintLayer, TracePhaseBegin, &TimelineTraceEventProcessor::onPaintLayerBegin); > - registerHandler(InstrumentationEvents::PaintLayer, TracePhaseEnd, &TimelineTraceEventProcessor::onPaintLayerEnd); > - registerHandler(InstrumentationEvents::RasterTask, TracePhaseBegin, &TimelineTraceEventProcessor::onRasterTaskBegin); > - registerHandler(InstrumentationEvents::RasterTask, TracePhaseEnd, &TimelineTraceEventProcessor::onRasterTaskEnd); > - registerHandler(InstrumentationEvents::Layer, TracePhaseDeleteObject, &TimelineTraceEventProcessor::onLayerDeleted); > - registerHandler(InstrumentationEvents::Paint, TracePhaseInstant, &TimelineTraceEventProcessor::onPaint); I think this was the only user of InstrumentationEvents and InstrumentationEventArguments. You can remove the enum / strings in InspectorInstrumentation.*: inspector/InspectorInstrumentation.cpp 1390:namespace InstrumentationEvents { 1398:namespace InstrumentationEventArguments { inspector/InspectorInstrumentation.h 515:namespace InstrumentationEvents { 523:namespace InstrumentationEventArguments {
Timothy Hatcher
Comment 3 2013-09-11 11:58:57 PDT
http://trac.webkit.org/changeset/155549
Note You need to log in before you can comment on or make changes to this bug.