Summary: | MapData and WeakMapData don't need to be objects | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 120954 | ||||||
Attachments: |
|
Description
Sam Weinig
2013-09-11 10:24:03 PDT
Created attachment 211327 [details]
Patch
This will help with implementing the update Promises spec (120954). Comment on attachment 211327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211327&action=review Nice! > Source/JavaScriptCore/runtime/MapData.h:82 > + static const bool needsDestruction = true; > + static const bool hasImmortalStructure = true; I wonder if we should make a JSDestructibleCell base class, to make this easier in general. (In reply to comment #3) > (From update of attachment 211327 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=211327&action=review > > Nice! > > > Source/JavaScriptCore/runtime/MapData.h:82 > > + static const bool needsDestruction = true; > > + static const bool hasImmortalStructure = true; > > I wonder if we should make a JSDestructibleCell base class, to make this easier in general. Might make sense. I'll look into to that. Comment on attachment 211327 [details] Patch Clearing flags on attachment: 211327 Committed r155558: <http://trac.webkit.org/changeset/155558> All reviewed patches have been landed. Closing bug. |