Bug 121149

Summary:

[ATK] Adds mapping MenuItemRadioRole to ATK

Product:

WebKit

Reporter:

Krzysztof Czech <k.czech>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cdumez, cfleizach, commit-queue, dmazzoni, gyuyoung.kim, jdiggs, mario, rakuco, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mario: review+, mario: commit-queue-
Patch	none

Description Krzysztof Czech 2013-09-11 02:41:16 PDT

MenuItemRadioRole is a new AccessibilityRole that appeared after r155492.
I'm adding mapping to ATK.

Comment 1 Radar WebKit Bug Importer 2013-09-11 02:41:27 PDT

<rdar://problem/14962891>

Comment 2 Krzysztof Czech 2013-09-11 02:52:43 PDT

Created attachment 211292 [details]
Patch

Comment 3 Mario Sanchez Prada 2013-09-11 03:10:09 PDT

Comment on attachment 211292 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211292&action=review

Looks good to me, but there's an extra line that should be removed before landing

> LayoutTests/ChangeLog:11
> +        * platform/gtk/accessibility/aria-menubar-menuitems-expected.txt:

Thanks for adding the GTK expectation

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:234
> +

Wrong extra line

Comment 4 Krzysztof Czech 2013-09-11 03:24:51 PDT

Created attachment 211294 [details]
Patch

Comment 5 Krzysztof Czech 2013-09-11 03:25:55 PDT

> > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:234
> > +
> 
> Wrong extra line
Indeed, ups. Already corrected.

Comment 6 WebKit Commit Bot 2013-09-11 04:30:14 PDT

Comment on attachment 211294 [details]
Patch

Clearing flags on attachment: 211294

Committed r155518: <http://trac.webkit.org/changeset/155518>

Comment 7 WebKit Commit Bot 2013-09-11 04:30:18 PDT

All reviewed patches have been landed.  Closing bug.