Bug 121132

Summary:

Propagate the Int48 stuff into the prediction propagator.

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, gtk-ews, mark.lam, mhahnenberg, msaboff, oliver, sam, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
the patch	mhahnenberg: review+, gtk-ews: commit-queue-

Filip Pizlo

Reported 2013-09-10 16:37:12 PDT

Patch forthcoming.

Attachments
the patch (13.18 KB, patch) 2013-09-10 16:38 PDT, Filip Pizlo	mhahnenberg: review+ gtk-ews: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2013-09-10 16:38:39 PDT

Mark Hahnenberg

Comment 2 2013-09-10 16:48:52 PDT

Comment on attachment 211263 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=211263&action=review r=me > Source/JavaScriptCore/dfg/DFGNodeFlags.h:101 > if (flags & NodeMayOverflow) Call helper. > Source/JavaScriptCore/dfg/DFGNodeFlags.h:112 > + if (flags & NodeMayNegZero) Call helper.

kov's GTK+ EWS bot

Comment 3 2013-09-10 21:30:55 PDT

Filip Pizlo

Comment 4 2013-09-10 21:32:48 PDT

(In reply to comment #3) > (From update of attachment 211263 [details]) > Attachment 211263 [details] did not pass gtk-ews (gtk): > Output: http://webkit-queues.appspot.com/results/1742522 This fail is because GTK+ is applying this patch on top of http://trac.webkit.org/changeset/155497 without rebasing. The patch I'm about to land has been correctly rebased so it should work.

Filip Pizlo

Comment 5 2013-09-10 21:34:39 PDT

Note You need to log in before you can comment on or make changes to this bug.