Bug 121112
| Summary: | Re-enable pixel tests on the build bots | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | WebKit Commit Bot <commit-queue> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | rniwa, robert |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=221618 | ||
| Bug Depends on: | |||
| Bug Blocks: | 121035 | ||
WebKit Commit Bot
Re-enable pixel tests on the build bots
Requested by rhogan on #webkit.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Robert Hogan
Since Blink forked none of the build bots are running pixel tests.
This means that we are not catching painting regressions where the rendertree text dump is unaffected by the regression.
Given that in the vast majority of cases a rebaseline to the pixel result also entails a rebaseline to the rendertree result and vice versa the additional overhead of enabling pixel tests and keeping them up to date is not the 'current effort x 2'. In most cases the rebaselining needs to be done anyway, the rebaseliner just needs to update the png result while they're at it.