Bug 121093

Summary:

[GTK] The code generator produces a warning if a parameter can be NULL

Product:

WebKit

Reporter:

Alberto Garcia <berto>

Component:

WebKitGTK

Assignee:

Alberto Garcia <berto>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cdumez: review+

Description Alberto Garcia 2013-09-10 06:13:24 PDT

Here's the warning:

  GEN      DerivedSources/webkitdom/WebKitDOMDOMWindow.h
Use of uninitialized value $CodeGeneratorGObject::cBody[129] in print at ../../Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm line 1536.

The problem is in the generator of the g_return_if_fail() checks at the beginning of each method.

If a particular parameter can be null the generator returns an undefined value instead of an empty string.

Comment 1 Alberto Garcia 2013-09-10 06:15:13 PDT

Created attachment 211194 [details]
Patch

Comment 2 Chris Dumez 2013-09-10 06:25:11 PDT

Comment on attachment 211194 [details]
Patch

r=me

Comment 3 Alberto Garcia 2013-09-10 06:31:45 PDT

Committed r155435: <http://trac.webkit.org/changeset/155435>