Summary: | Change virtual register function arguments and locals from unsigned to int | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 118758 | ||||||
Attachments: |
|
Description
Michael Saboff
2013-09-09 15:37:33 PDT
Created attachment 211108 [details]
Patch
Builds and passes JS tests for both 32 and 64 bit.
Comment on attachment 211108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211108&action=review > Source/JavaScriptCore/ChangeLog:8 > + This is a largely mechanical change. This changes function paramaters and local variables use to Should be "used". > Source/JavaScriptCore/ChangeLog:19 > + * bytecode/CodeOrigin.h: > + * dfg/DFGByteCodeParser.cpp: > + (JSC::DFG::ByteCodeParser::getDirect): > + (JSC::DFG::ByteCodeParser::setDirect): > + (JSC::DFG::ByteCodeParser::getLocal): > + (JSC::DFG::ByteCodeParser::setLocal): > + (JSC::DFG::ByteCodeParser::parseBlock): > + * jit/JIT.h: > + (JSC::JIT::emitStoreCell): I don't think this empty function list is super helpful. Perhaps you could truncate it to a file list. Committed r155418: <http://trac.webkit.org/changeset/155418> |