Bug 121047

Summary: Remove wtf/TypeTraits.h
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cmarcelo, commit-queue, gtk-ews, gyuyoung.kim, rakuco, rego+ews, rniwa, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Anders Carlsson
Reported 2013-09-09 14:05:46 PDT
Remove wtf/TypeTraits.h
Attachments
Patch (30.43 KB, patch)
2013-09-09 14:06 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (31.34 KB, patch)
2013-09-09 14:51 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (31.28 KB, patch)
2013-09-09 14:53 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (31.98 KB, patch)
2013-09-09 14:58 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (32.61 KB, patch)
2013-09-09 15:01 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (33.67 KB, patch)
2013-09-09 15:08 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (36.29 KB, patch)
2013-09-09 15:40 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-09-09 14:06:59 PDT
Created attachment 211083 [details] Patch
Andreas Kling
Comment 2 2013-09-09 14:08:17 PDT
Comment on attachment 211083 [details] Patch Cool.
Early Warning System Bot
Comment 3 2013-09-09 14:20:10 PDT
Comment on attachment 211083 [details] Patch Attachment 211083 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1737263
Early Warning System Bot
Comment 4 2013-09-09 14:22:08 PDT
Comment on attachment 211083 [details] Patch Attachment 211083 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1719982
Build Bot
Comment 5 2013-09-09 14:36:05 PDT
Comment on attachment 211083 [details] Patch Attachment 211083 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1725641
Build Bot
Comment 6 2013-09-09 14:49:58 PDT
Comment on attachment 211083 [details] Patch Attachment 211083 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1734410
Anders Carlsson
Comment 7 2013-09-09 14:51:24 PDT
Created attachment 211090 [details] Patch
Anders Carlsson
Comment 8 2013-09-09 14:53:48 PDT
Created attachment 211092 [details] Patch
Anders Carlsson
Comment 9 2013-09-09 14:58:41 PDT
Created attachment 211095 [details] Patch
Anders Carlsson
Comment 10 2013-09-09 15:01:29 PDT
Created attachment 211096 [details] Patch
Anders Carlsson
Comment 11 2013-09-09 15:08:42 PDT
Created attachment 211099 [details] Patch
Darin Adler
Comment 12 2013-09-09 15:14:45 PDT
Comment on attachment 211099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211099&action=review > Source/JavaScriptCore/jsc.cpp:-264 > -COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false); Why was this here? Why is it going? > Source/JavaScriptCore/testRegExp.cpp:-142 > -COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false); Why was this here? Why is it going?
Early Warning System Bot
Comment 13 2013-09-09 15:35:08 PDT
Comment on attachment 211099 [details] Patch Attachment 211099 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1728509
Early Warning System Bot
Comment 14 2013-09-09 15:35:35 PDT
Comment on attachment 211099 [details] Patch Attachment 211099 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1742161
Build Bot
Comment 15 2013-09-09 15:36:29 PDT
Comment on attachment 211099 [details] Patch Attachment 211099 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1736419
kov's GTK+ EWS bot
Comment 16 2013-09-09 15:36:41 PDT
Comment on attachment 211099 [details] Patch Attachment 211099 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1743011
Anders Carlsson
Comment 17 2013-09-09 15:36:52 PDT
(In reply to comment #12) > (From update of attachment 211099 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=211099&action=review > > > Source/JavaScriptCore/jsc.cpp:-264 > > -COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false); > > Why was this here? Why is it going? I have no idea why it was there. GlobalObject is a class so asserting that it’s not an integer seems pointless. > > > Source/JavaScriptCore/testRegExp.cpp:-142 > > -COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false); > > Why was this here? Why is it going? I think it’s either been copied from jsc.cpp, or the other way around.
Anders Carlsson
Comment 18 2013-09-09 15:40:58 PDT
Created attachment 211106 [details] Patch
WebKit Commit Bot
Comment 19 2013-09-09 16:36:42 PDT
Comment on attachment 211106 [details] Patch Clearing flags on attachment: 211106 Committed r155402: <http://trac.webkit.org/changeset/155402>
WebKit Commit Bot
Comment 20 2013-09-09 16:36:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.