Bug 121034 – MediaStreamDescriptor::removeAudioComponent accidentally changes m_videoComponents

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Thiago de Barros Lacerda]

removeAudioComponent is calling remove in video components vector by mistake

[Thiago de Barros Lacerda]

Created attachment 211057 [details]
Patch

[Alexey Proskuryakov]

Re-titled - we use bracketed prefixes for special interest bugs that most people just want to quickly skip over (like platform specific issues).

[WebKit Commit Bot]

Comment on attachment 211057 [details]
Patch

Clearing flags on attachment: 211057

Committed r155382: <http://trac.webkit.org/changeset/155382>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 211057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211057&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests needed.

Why? Looks like this was a bad bug. Normally we’d want a regression test.

[Thiago de Barros Lacerda]

(In reply to comment #5)
> (From update of attachment 211057 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211057&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests needed.
> 
> Why? Looks like this was a bad bug. Normally we’d want a regression test.

Darin, this was just introduced by accident in this revision https://bugs.webkit.org/show_bug.cgi?id=120872. So I think does not need an Test for that