Bug 121034

Summary: MediaStreamDescriptor::removeAudioComponent accidentally changes m_videoComponents
Product: WebKit Reporter: Thiago de Barros Lacerda <thiago.lacerda>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, hta, jer.noble, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Thiago de Barros Lacerda 2013-09-09 10:53:59 PDT 
removeAudioComponent is calling remove in video components vector by mistake
Comment 1 Thiago de Barros Lacerda 2013-09-09 10:55:30 PDT 
Created attachment 211057 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-09-09 12:39:04 PDT 
Re-titled - we use bracketed prefixes for special interest bugs that most people just want to quickly skip over (like platform specific issues).
Comment 3 WebKit Commit Bot 2013-09-09 14:31:50 PDT 
Comment on attachment 211057 [details]
Patch

Clearing flags on attachment: 211057

Committed r155382: <http://trac.webkit.org/changeset/155382>
Comment 4 WebKit Commit Bot 2013-09-09 14:31:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2013-09-09 14:41:48 PDT 
Comment on attachment 211057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211057&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests needed.

Why? Looks like this was a bad bug. Normally we’d want a regression test.
Comment 6 Thiago de Barros Lacerda 2013-09-09 14:46:47 PDT 
(In reply to comment #5)
> (From update of attachment 211057 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211057&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests needed.
> 
> Why? Looks like this was a bad bug. Normally we’d want a regression test.

Darin, this was just introduced by accident in this revision https://bugs.webkit.org/show_bug.cgi?id=120872. So I think does not need an Test for that