Bug 121029

Summary: matchingShorthandsForLonghand builds map using a giant function
Product: WebKit Reporter: Darin Adler <darin>
Component: CSSAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, esprehn+autocc, glenn, kling, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Darin Adler
Reported 2013-09-09 08:38:38 PDT
matchingShorthandsForLonghand builds map using a giant function
Attachments
Patch (73.99 KB, patch)
2013-09-09 08:48 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-09-09 08:48:00 PDT
Created attachment 211045 [details] Patch
Anders Carlsson
Comment 2 2013-09-09 08:56:36 PDT
Comment on attachment 211045 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211045&action=review > Source/WebCore/css/StylePropertyShorthand.cpp:598 > +static Vector<StylePropertyShorthand> makeVector(const StylePropertyShorthand& a) > +{ > + return Vector<StylePropertyShorthand>(1, a); > +} I wish we could use std::initializer_list so we wouldn't need any of these helpers!
WebKit Commit Bot
Comment 3 2013-09-09 09:26:56 PDT
Comment on attachment 211045 [details] Patch Clearing flags on attachment: 211045 Committed r155352: <http://trac.webkit.org/changeset/155352>
WebKit Commit Bot
Comment 4 2013-09-09 09:26:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.