Bug 121028

Summary: Hide Document::renderer()
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Description Antti Koivisto 2013-09-09 03:29:10 PDT 
Use Document::renderView() instead.
Comment 1 Antti Koivisto 2013-09-09 03:31:46 PDT 
Created attachment 211024 [details]
patch
Comment 2 Andreas Kling 2013-09-09 03:33:30 PDT 
Comment on attachment 211024 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211024&action=review

A+, good patch, would review again!

> Source/WebCore/dom/Document.h:-546
> -    // FIXME: Remove this, callers that have a Document* should call renderView().
> -    // Shadow the implementations on Node to provide faster access for documents.
> -    RenderView* renderer() const { return m_renderView; }

Thanks for fixing my FIXME! :D
Comment 3 Antti Koivisto 2013-09-09 03:36:52 PDT 
https://trac.webkit.org/r155344
Comment 4 Darin Adler 2013-09-09 09:49:20 PDT 
Comment on attachment 211024 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211024&action=review

> Source/WebCore/dom/Document.h:1187
> +    RenderObject* renderer() const WTF_DELETED_FUNCTION;

In cases like this I often just make the return type void.