Bug 121017

Summary: Deprecate AdoptCF and AdoptNS (on all platforms except iOS for now)
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cmarcelo, commit-queue, kling, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch kling: review+, kling: commit-queue+

Darin Adler
Reported 2013-09-08 20:11:06 PDT
Deprecate AdoptCF and AdoptNS (on all platforms except iOS for now)
Attachments
Patch (2.35 KB, patch)
2013-09-08 20:13 PDT, Darin Adler 		kling: review+
kling: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-09-08 20:13:11 PDT
Created attachment 211004 [details] Patch
Darin Adler
Comment 2 2013-09-08 20:13:58 PDT
Really only affects Mac, iOS, and Windows ports like Apple’s that use Core Foundation. But I didn’t know how to specify that in a bug title prefix.
WebKit Commit Bot
Comment 3 2013-09-08 20:14:55 PDT
Attachment 211004 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/RetainPtr.h']" exit_code: 1 Source/WTF/wtf/RetainPtr.h:53: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WTF/wtf/RetainPtr.h:53: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] Source/WTF/wtf/RetainPtr.h:54: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] Source/WTF/wtf/RetainPtr.h:342: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] Source/WTF/wtf/RetainPtr.h:343: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 4 2013-09-08 20:47:12 PDT
Comment on attachment 211004 [details] Patch Okay.
Darin Adler
Comment 5 2013-09-08 20:53:12 PDT
Committed r155319: <http://trac.webkit.org/changeset/155319>
Note You need to log in before you can comment on or make changes to this bug.