Bug 121017 - Deprecate AdoptCF and AdoptNS (on all platforms except iOS for now)
Summary: Deprecate AdoptCF and AdoptNS (on all platforms except iOS for now)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-08 20:11 PDT by Darin Adler
Modified: 2013-09-08 20:53 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.35 KB, patch)
2013-09-08 20:13 PDT, Darin Adler
kling: review+
kling: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-09-08 20:11:06 PDT
Deprecate AdoptCF and AdoptNS (on all platforms except iOS for now)
Comment 1 Darin Adler 2013-09-08 20:13:11 PDT
Created attachment 211004 [details]
Patch
Comment 2 Darin Adler 2013-09-08 20:13:58 PDT
Really only affects Mac, iOS, and Windows ports like Apple’s that use Core Foundation. But I didn’t know how to specify that in a bug title prefix.
Comment 3 WebKit Commit Bot 2013-09-08 20:14:55 PDT
Attachment 211004 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/RetainPtr.h']" exit_code: 1
Source/WTF/wtf/RetainPtr.h:53:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WTF/wtf/RetainPtr.h:53:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WTF/wtf/RetainPtr.h:54:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WTF/wtf/RetainPtr.h:342:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WTF/wtf/RetainPtr.h:343:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Total errors found: 5 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andreas Kling 2013-09-08 20:47:12 PDT
Comment on attachment 211004 [details]
Patch

Okay.
Comment 5 Darin Adler 2013-09-08 20:53:12 PDT
Committed r155319: <http://trac.webkit.org/changeset/155319>