Summary: | <iframe>: The last valid content gets loaded when history navigating. | ||
---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> |
Component: | History | Assignee: | zalan <zalan> |
Status: | ASSIGNED --- | ||
Severity: | Normal | CC: | ap, beidson, buildbot, commit-queue, japhet, rniwa |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Attachments: |
Description
zalan
2013-09-08 11:29:55 PDT
Created attachment 210986 [details]
Patch
The patch might be too aggressive in removing existing history items and we could do something more specific, like removing/updating only when the url change triggers the error. HistoryItem* child = parentHistoryItem->childItemWithTarget(m_frame.tree().uniqueName()); if (child && child->url() != error.failingURL()) parentHistoryItem->removeChildItem(child); Comment on attachment 210986 [details] Patch Attachment 210986 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1733097 New failing tests: http/tests/navigation/post-frames-goback1-uncached.html http/tests/navigation/forward-and-cancel.html Created attachment 210990 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
Comment on attachment 210986 [details] Patch Attachment 210986 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1734121 New failing tests: http/tests/navigation/post-frames-goback1-uncached.html http/tests/navigation/forward-and-cancel.html Created attachment 210993 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Comment on attachment 210986 [details] Patch Attachment 210986 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1728185 New failing tests: http/tests/navigation/post-frames-goback1-uncached.html http/tests/navigation/forward-and-cancel.html Created attachment 210998 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Created attachment 211558 [details]
Patch
|