Bug 121004

Summary: FrameView::scheduleEvent() is over-engineered.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch idea
koivisto: review+
Land none

Andreas Kling
Reported 2013-09-08 03:14:21 PDT
FrameView::scheduleEvent() is over-engineered.
Attachments
Patch idea (21.46 KB, patch)
2013-09-08 03:23 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
Land (21.55 KB, patch)
2013-09-08 13:22 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-08 03:23:27 PDT
Created attachment 210974 [details] Patch idea
Antti Koivisto
Comment 2 2013-09-08 03:35:44 PDT
Comment on attachment 210974 [details] Patch idea View in context: https://bugs.webkit.org/attachment.cgi?id=210974&action=review > Source/WebCore/page/FrameView.h:671 > + unsigned m_shouldEnqueueEvents; This sounds like a boolean. m_scheduledEventSuppressionCount or similar would be better.
Andreas Kling
Comment 3 2013-09-08 13:22:35 PDT
Created attachment 210989 [details] Land
WebKit Commit Bot
Comment 4 2013-09-08 14:10:02 PDT
Comment on attachment 210989 [details] Land Clearing flags on attachment: 210989 Committed r155315: <http://trac.webkit.org/changeset/155315>
WebKit Commit Bot
Comment 5 2013-09-08 14:10:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.