Bug 121004

Summary: FrameView::scheduleEvent() is over-engineered.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch idea
koivisto: review+
Land none

Description Andreas Kling 2013-09-08 03:14:21 PDT
FrameView::scheduleEvent() is over-engineered.
Comment 1 Andreas Kling 2013-09-08 03:23:27 PDT
Created attachment 210974 [details]
Patch idea
Comment 2 Antti Koivisto 2013-09-08 03:35:44 PDT
Comment on attachment 210974 [details]
Patch idea

View in context: https://bugs.webkit.org/attachment.cgi?id=210974&action=review

> Source/WebCore/page/FrameView.h:671
> +    unsigned m_shouldEnqueueEvents;

This sounds like a boolean. m_scheduledEventSuppressionCount or similar would be better.
Comment 3 Andreas Kling 2013-09-08 13:22:35 PDT
Created attachment 210989 [details]
Land
Comment 4 WebKit Commit Bot 2013-09-08 14:10:02 PDT
Comment on attachment 210989 [details]
Land

Clearing flags on attachment: 210989

Committed r155315: <http://trac.webkit.org/changeset/155315>
Comment 5 WebKit Commit Bot 2013-09-08 14:10:05 PDT
All reviewed patches have been landed.  Closing bug.