Bug 121004 - FrameView::scheduleEvent() is over-engineered.
Summary: FrameView::scheduleEvent() is over-engineered.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2013-09-08 03:14 PDT by Andreas Kling
Modified: 2013-09-08 14:10 PDT (History)
3 users (show)

See Also:

Patch idea (21.46 KB, patch)
2013-09-08 03:23 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff
Land (21.55 KB, patch)
2013-09-08 13:22 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-08 03:14:21 PDT
FrameView::scheduleEvent() is over-engineered.
Comment 1 Andreas Kling 2013-09-08 03:23:27 PDT
Created attachment 210974 [details]
Patch idea
Comment 2 Antti Koivisto 2013-09-08 03:35:44 PDT
Comment on attachment 210974 [details]
Patch idea

View in context: https://bugs.webkit.org/attachment.cgi?id=210974&action=review

> Source/WebCore/page/FrameView.h:671
> +    unsigned m_shouldEnqueueEvents;

This sounds like a boolean. m_scheduledEventSuppressionCount or similar would be better.
Comment 3 Andreas Kling 2013-09-08 13:22:35 PDT
Created attachment 210989 [details]
Comment 4 WebKit Commit Bot 2013-09-08 14:10:02 PDT
Comment on attachment 210989 [details]

Clearing flags on attachment: 210989

Committed r155315: <http://trac.webkit.org/changeset/155315>
Comment 5 WebKit Commit Bot 2013-09-08 14:10:05 PDT
All reviewed patches have been landed.  Closing bug.