Bug 120983

Summary: gtest fails to build due to integer type mismatch in WTF::insertIntoBoundedVector()
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Web Template FrameworkAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cmarcelo, commit-queue, darin, ddkilzer, fpizlo, mhahnenberg, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2013-09-07 18:02:55 PDT
When gtest builds for the Debug configuration, I see the following error: WebKitBuild/Debug/usr/local/include/wtf/StdLibExtras.h:266:23: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32] for (unsigned i = size; i-- > index + 1;) ~ ^~~~ 1 error generated.
Attachments
Patch v1 (1.68 KB, patch)
2013-09-07 18:07 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2013-09-07 18:07:22 PDT
Created attachment 210941 [details] Patch v1
WebKit Commit Bot
Comment 2 2013-09-07 20:45:23 PDT
Comment on attachment 210941 [details] Patch v1 Clearing flags on attachment: 210941 Committed r155280: <http://trac.webkit.org/changeset/155280>
WebKit Commit Bot
Comment 3 2013-09-07 20:45:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.