Bug 120959

Summary: VectorMover should use std::move
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, ggaren, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Anders Carlsson
Reported 2013-09-07 11:06:10 PDT
VectorMover should use std::move
Attachments
Patch (2.78 KB, patch)
2013-09-07 11:08 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (4.14 KB, patch)
2013-09-07 12:23 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-09-07 11:08:01 PDT
Created attachment 210913 [details] Patch
Early Warning System Bot
Comment 2 2013-09-07 11:16:50 PDT
Comment on attachment 210913 [details] Patch Attachment 210913 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1723005
Early Warning System Bot
Comment 3 2013-09-07 11:20:17 PDT
Comment on attachment 210913 [details] Patch Attachment 210913 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1703996
Geoffrey Garen
Comment 4 2013-09-07 11:41:13 PDT
/home/webkit/WebKit/Source/JavaScriptCore/bytecode/CallLinkInfo.h:45:8: error: invalid conversion from 'unsigned char:5' to 'JSC::CallLinkInfo::CallType' [-fpermissive] I guess this means that the Qt compiler needs an explicit move constructor for CallLinkInfo, since it isn't willing to implicitly copy a typed bitfield?
Geoffrey Garen
Comment 5 2013-09-07 11:41:29 PDT
Comment on attachment 210913 [details] Patch r=me
Anders Carlsson
Comment 6 2013-09-07 11:54:29 PDT
(In reply to comment #4) > /home/webkit/WebKit/Source/JavaScriptCore/bytecode/CallLinkInfo.h:45:8: error: invalid conversion from 'unsigned char:5' to 'JSC::CallLinkInfo::CallType' [-fpermissive] > > I guess this means that the Qt compiler needs an explicit move constructor for CallLinkInfo, since it isn't willing to implicitly copy a typed bitfield? I think it’s a bug in that particular version of GCC. I am going to change the bitfield type to unsigned instead.
Anders Carlsson
Comment 7 2013-09-07 12:23:39 PDT
Created attachment 210916 [details] Patch
Anders Carlsson
Comment 8 2013-09-07 12:45:05 PDT
Committed r155258: <http://trac.webkit.org/changeset/155258>
Note You need to log in before you can comment on or make changes to this bug.