Bug 120955

Summary:

removing --dialog-element from build-webkit --help option message

Product:

WebKit

Reporter:

Santosh Mahto <santosh.ma>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

commit-queue, dbates

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

120467

Bug Blocks:

Attachments:

Description	Flags
Patch	none
patch for landing	none

Description Santosh Mahto 2013-09-07 09:21:12 PDT

$Tools/Script/build-webkit  --help

-[no-]data-transfer-items        Toggle Data Transfer Items support (default: 0)
  --[no-]details-element            Toggle Details Element support (default: 1)
  --[no-]device-orientation         Toggle Device Orientation support (default: )
  --[no-]dialog-element             Toggle Dialog Element support (default: 0)   --->   Need to Remove
  --[no-]directory-upload           Toggle Directory Upload support (default: 0)
  --[no-]dom4-events-constructor    Expose DOM4 Events constructors (default: 1)


Dialog element  feature has been removed from webkit.
So it should not be display in  help message.

Comment 1 Santosh Mahto 2013-09-07 09:32:09 PDT

Created attachment 210910 [details]
Patch

Comment 2 Daniel Bates 2013-09-07 10:20:24 PDT

Comment on attachment 210910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210910&action=review

> Tools/ChangeLog:3
> +        removing --dialog-element  from build-webkit --help  option message

Nit: Please remove the extra space characters before "from" and before "option".

> Tools/ChangeLog:7
> +

Please add a description to explain that we're removing --dialog-element because we removed dialog element support in <http://trac.webkit.org/changeset/154835> and <http://trac.webkit.org/changeset/154870>.

Comment 3 Santosh Mahto 2013-09-07 10:41:45 PDT

Created attachment 210912 [details]
patch for landing

Comment 4 WebKit Commit Bot 2013-09-07 11:55:25 PDT

Comment on attachment 210912 [details]
patch for landing

Clearing flags on attachment: 210912

Committed r155256: <http://trac.webkit.org/changeset/155256>

Comment 5 WebKit Commit Bot 2013-09-07 11:55:27 PDT

All reviewed patches have been landed.  Closing bug.