Bug 120955

Summary:

removing --dialog-element from build-webkit --help option message

Product:

WebKit

Reporter:

Santosh Mahto <santosh.ma>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

commit-queue, dbates

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

120467

Bug Blocks:

Attachments:

Description	Flags
Patch	none
patch for landing	none

Santosh Mahto

Reported 2013-09-07 09:21:12 PDT

$Tools/Script/build-webkit --help -[no-]data-transfer-items Toggle Data Transfer Items support (default: 0) --[no-]details-element Toggle Details Element support (default: 1) --[no-]device-orientation Toggle Device Orientation support (default: ) --[no-]dialog-element Toggle Dialog Element support (default: 0) ---> Need to Remove --[no-]directory-upload Toggle Directory Upload support (default: 0) --[no-]dom4-events-constructor Expose DOM4 Events constructors (default: 1) Dialog element feature has been removed from webkit. So it should not be display in help message.

Attachments
Patch (1.71 KB, patch) 2013-09-07 09:32 PDT, Santosh Mahto	no flags	Details Formatted Diff Diff
patch for landing (1.94 KB, patch) 2013-09-07 10:41 PDT, Santosh Mahto	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Santosh Mahto

Comment 1 2013-09-07 09:32:09 PDT

Created attachment 210910 [details] Patch

Daniel Bates

Comment 2 2013-09-07 10:20:24 PDT

Comment on attachment 210910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210910&action=review > Tools/ChangeLog:3 > + removing --dialog-element from build-webkit --help option message Nit: Please remove the extra space characters before "from" and before "option". > Tools/ChangeLog:7 > + Please add a description to explain that we're removing --dialog-element because we removed dialog element support in <http://trac.webkit.org/changeset/154835> and <http://trac.webkit.org/changeset/154870>.

Santosh Mahto

Comment 3 2013-09-07 10:41:45 PDT

Created attachment 210912 [details] patch for landing

WebKit Commit Bot

Comment 4 2013-09-07 11:55:25 PDT

Comment on attachment 210912 [details] patch for landing Clearing flags on attachment: 210912 Committed r155256: <http://trac.webkit.org/changeset/155256>

WebKit Commit Bot

Comment 5 2013-09-07 11:55:27 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.