Bug 120882 – MediaStream API: Storing the constraints in MediaStreamSource

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Eric Carlson]

Consider merging https://chromium.googlesource.com/chromium/blink/+/04ac7655b54ae98f55774afde3f8e92b6c6302e6 

It was requested that the constraints object, if any, should be stored in the
source for later referencing. The first user of this is WebAudio but for consistency
the video constraints are stored as well.

[Thiago de Barros Lacerda]

Created attachment 211669 [details]
Patch

[Eric Carlson]

Comment on attachment 211669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211669&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests needed.

Please note the Blink revision this was merged from.

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:150
> +        (*iter)->component()->source()->setConstraints(m_audio);
> +
> +
> +    MediaStreamTrackVector videoTracks = stream->getVideoTracks();

Nit: you have an extra blank line here.

[Thiago de Barros Lacerda]

Created attachment 211779 [details]
Patch

[Thiago de Barros Lacerda]

Removed extra line and removed unnecessary vector creation inside UserMediaRequest::succeed method

[WebKit Commit Bot]

Comment on attachment 211779 [details]
Patch

Clearing flags on attachment: 211779

Committed r155881: <http://trac.webkit.org/changeset/155881>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.