Bug 120882

Summary: MediaStream API: Storing the constraints in MediaStreamSource
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Thiago de Barros Lacerda <thiago.lacerda>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, hta, jer.noble, tommyw
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121101    
Attachments:
Description Flags
Patch
none
Patch none

Description Eric Carlson 2013-09-06 12:36:41 PDT 
Consider merging https://chromium.googlesource.com/chromium/blink/+/04ac7655b54ae98f55774afde3f8e92b6c6302e6 

It was requested that the constraints object, if any, should be stored in the
source for later referencing. The first user of this is WebAudio but for consistency
the video constraints are stored as well.
Comment 1 Thiago de Barros Lacerda 2013-09-14 15:26:38 PDT 
Created attachment 211669 [details]
Patch
Comment 2 Eric Carlson 2013-09-14 16:15:41 PDT 
Comment on attachment 211669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211669&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests needed.

Please note the Blink revision this was merged from.

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:150
> +        (*iter)->component()->source()->setConstraints(m_audio);
> +
> +
> +    MediaStreamTrackVector videoTracks = stream->getVideoTracks();

Nit: you have an extra blank line here.
Comment 3 Thiago de Barros Lacerda 2013-09-16 07:07:02 PDT 
Created attachment 211779 [details]
Patch
Comment 4 Thiago de Barros Lacerda 2013-09-16 07:08:17 PDT 
Removed extra line and removed unnecessary vector creation inside UserMediaRequest::succeed method
Comment 5 WebKit Commit Bot 2013-09-16 10:20:30 PDT 
Comment on attachment 211779 [details]
Patch

Clearing flags on attachment: 211779

Committed r155881: <http://trac.webkit.org/changeset/155881>
Comment 6 WebKit Commit Bot 2013-09-16 10:20:32 PDT 
All reviewed patches have been landed.  Closing bug.