|Summary:||Make MediaStream objects ScriptWrappable|
|Product:||WebKit||Reporter:||Eric Carlson <eric.carlson>|
|Component:||WebCore Misc.||Assignee:||Eric Carlson <eric.carlson>|
|Severity:||Normal||CC:||commit-queue, eric.carlson, glenn, hta, jer.noble, oliver, sam, tommyw|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Eric Carlson 2013-09-06 11:59:08 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/621822b20d5b0ceceb000b3c02ae82cce5063c51 This change allows binding intergrity checks to be applied to these obects.
Comment 2 Jer Noble 2013-09-10 14:15:26 PDT
Comment on attachment 211241 [details] Proposed patch LGTM. r=me.
Comment 3 Sam Weinig 2013-09-10 14:21:46 PDT
I'm not against this change, but I don't follow the reasoning. What about making them ScriptWrappable helps with the integrity checks. I think the only thing needed for those checks is a vtable.
Comment 4 Sam Weinig 2013-09-10 14:22:23 PDT
I'd like Oliver to comment before landing.
Comment 5 Oliver Hunt 2013-09-10 14:25:30 PDT
Comment 6 WebKit Commit Bot 2013-09-10 14:47:37 PDT
Comment on attachment 211241 [details] Proposed patch Clearing flags on attachment: 211241 Committed r155478: <http://trac.webkit.org/changeset/155478>
Comment 7 WebKit Commit Bot 2013-09-10 14:47:39 PDT
All reviewed patches have been landed. Closing bug.
Comment 8 Sam Weinig 2013-09-10 15:11:36 PDT
(In reply to comment #5) > Looks good Oliver, what about making them ScriptWrappable helps with the integrity checks?
Comment 9 Eric Carlson 2013-09-11 09:20:54 PDT
(In reply to comment #8) > (In reply to comment #5) > > Looks good > > Oliver, what about making them ScriptWrappable helps with the integrity checks? I talked to Geoff about this patch before I posted it. He said that with JSC it won't help with "binding integrity checks", but that it I might as well merge it to make future merges easier. The "This change allows binding intergrity checks to be applied to these obects" comment is from the blink bug. I didn't include it in the ChangeLog.