Summary: | Split MediaStreamDescriptor.h and MediaStreamComponent.h into .h and .cpp | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||
Component: | WebCore Misc. | Assignee: | Eric Carlson <eric.carlson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, glenn, gyuyoung.kim, hta, jer.noble, philn, rakuco, sergio, tommyw, xan.lopez | ||||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 121101 | ||||||||||
Attachments: |
|
Description
Eric Carlson
2013-09-06 11:57:24 PDT
Created attachment 211231 [details]
Proposed patch
Attachment 211231 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/mediastream/LocalMediaStream.cpp', u'Source/WebCore/Modules/mediastream/MediaStream.cpp', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/mediastream/MediaStreamComponent.cpp', u'Source/WebCore/platform/mediastream/MediaStreamComponent.h', u'Source/WebCore/platform/mediastream/MediaStreamDescriptor.cpp', u'Source/WebCore/platform/mediastream/MediaStreamDescriptor.h']" exit_code: 1
Source/WebCore/platform/mediastream/MediaStreamDescriptor.h:62: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 211232 [details]
Updated patch
Maybe add MediaStreamComponent.cpp and MediaStreamDescriptor.cpp to Source/WebCore/CMakeLists as well? Created attachment 211238 [details]
Include new files in CMakeLists.txt
Comment on attachment 211238 [details]
Include new files in CMakeLists.txt
LGTM. r=me.
Comment on attachment 211238 [details] Include new files in CMakeLists.txt Clearing flags on attachment: 211238 Committed r155477: <http://trac.webkit.org/changeset/155477> All reviewed patches have been landed. Closing bug. (In reply to comment #5) > Created an attachment (id=211238) [details] > Include new files in CMakeLists.txt The files were included in the CMakeList.txt with a wrong path, and caused build problems in EFL :) I submitted https://bugs.webkit.org/show_bug.cgi?id=121126 to fix it. (In reply to comment #9) > (In reply to comment #5) > > Created an attachment (id=211238) [details] [details] > > Include new files in CMakeLists.txt > > The files were included in the CMakeList.txt with a wrong path, and caused build problems in EFL :) > Sorry about that :-( > I submitted https://bugs.webkit.org/show_bug.cgi?id=121126 to fix it. > Thanks! |