| Summary: | MediaStream should fire ended event when all tracks are ended | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||
| Component: | WebCore Misc. | Assignee: | Eric Carlson <eric.carlson> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, glenn, hta, jer.noble, tommyw | ||||||||||
| Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 121101 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Eric Carlson
2013-09-06 11:44:54 PDT
Created attachment 210799 [details]
Proposed patch
Created attachment 210800 [details]
Updated patch, this time without already-landed-changes
Created attachment 210802 [details]
Patch that causes fewer regressions, AND with a complete ChangeLog!
Created attachment 210817 [details]
Updated patch
Comment on attachment 210817 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=210817&action=review r=me, with nit: > Source/WebCore/ChangeLog:4 > + MediaStream should fire ended event when all tracks are ended > + https://bugs.webkit.org/show_bug.cgi?id=120871 This should include a line stating that this is a blink merge, and include the URL to the blink commit. Comment on attachment 210817 [details] Updated patch (In reply to comment #5) > (From update of attachment 210817 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=210817&action=review > > r=me, with nit: > > > Source/WebCore/ChangeLog:4 > > + MediaStream should fire ended event when all tracks are ended > > + https://bugs.webkit.org/show_bug.cgi?id=120871 > > This should include a line stating that this is a blink merge, and include the URL to the blink commit. Oops, good point. Done. Committed r155249: https://trac.webkit.org/r155249 |