Bug 120830

Summary: FrameLoader::subframeLoader() should return a reference.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Page LoadingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, eric.carlson, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, japhet, jer.noble, kangil.han, kling, rego+ews, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eflews.bot: commit-queue-
Patch none

Andreas Kling
Reported 2013-09-06 00:15:42 PDT
FrameLoader::subresourceLoader() should return a reference.
Attachments
Patch (24.43 KB, patch)
2013-09-06 00:16 PDT, Andreas Kling 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (26.66 KB, patch)
2013-09-06 08:51 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-06 00:16:10 PDT
Created attachment 210708 [details] Patch
EFL EWS Bot
Comment 2 2013-09-06 00:24:27 PDT
Comment on attachment 210708 [details] Patch Attachment 210708 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1705280
Early Warning System Bot
Comment 3 2013-09-06 00:25:44 PDT
Comment on attachment 210708 [details] Patch Attachment 210708 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1706296
Early Warning System Bot
Comment 4 2013-09-06 00:25:53 PDT
Comment on attachment 210708 [details] Patch Attachment 210708 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1706295
EFL EWS Bot
Comment 5 2013-09-06 00:30:07 PDT
Comment on attachment 210708 [details] Patch Attachment 210708 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1696996
Build Bot
Comment 6 2013-09-06 00:58:36 PDT
Comment on attachment 210708 [details] Patch Attachment 210708 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1714099
kov's GTK+ EWS bot
Comment 7 2013-09-06 02:15:18 PDT
Comment on attachment 210708 [details] Patch Attachment 210708 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1717017
Andreas Kling
Comment 8 2013-09-06 08:51:14 PDT
Created attachment 210759 [details] Patch
WebKit Commit Bot
Comment 9 2013-09-06 10:22:03 PDT
Comment on attachment 210759 [details] Patch Clearing flags on attachment: 210759 Committed r155194: <http://trac.webkit.org/changeset/155194>
WebKit Commit Bot
Comment 10 2013-09-06 10:22:06 PDT
All reviewed patches have been landed. Closing bug.
Andreas Kling
Comment 11 2013-09-06 12:57:09 PDT
Ehrm, this was about SubframeLoader, not SubresourceLoader. Brain farts aplenty.
Note You need to log in before you can comment on or make changes to this bug.